Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Lint: add rustfmt config and CI workflow #13

Merged
merged 4 commits into from
Oct 31, 2020
Merged

Lint: add rustfmt config and CI workflow #13

merged 4 commits into from
Oct 31, 2020

Conversation

zoedberg
Copy link
Contributor

this PR adds a .rustfmt.toml file for rustfmt configuration, lints code, adds Lints github workflow and lint badge to README.

Is it ok to use nightly for the workflow? Should I switch to stable?

@zoedberg zoedberg requested a review from dr-orlovsky October 30, 2020 11:19
dr-orlovsky
dr-orlovsky approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! For linting we always use the nightly fmt, but I think you are right, since not each nightly releases fmt tool and it frequently breaks. So the best will be to stick to some specific rust version (and even not stable, since it also changes with time).

@dr-orlovsky
Copy link
Member

Btw can we also add build CI, something like https://github.com/LNP-BP/rgb-node/blob/master/.github/workflows/build.yml?

I understand that it will cover FFI lib only, but it would be nice to have, especially with lipo and target-specific build matrix, if possible. Feel free to do it as a separate PR

@zoedberg
Copy link
Contributor Author

So the best will be to stick to some specific rust version (and even not stable, since it also changes with time).

switched to rust 1.47.0

Btw can we also add build CI

yep, I'll do that in a separate PR

@dr-orlovsky dr-orlovsky merged commit ab59c77 into RGB-WG:master Oct 31, 2020
@dr-orlovsky dr-orlovsky added the enhancement New feature or request label Oct 31, 2020
@dr-orlovsky dr-orlovsky added this to the v0.1 milestone Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dr-orlovsky dr-orlovsky dr-orlovsky approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@zoedberg @dr-orlovsky